Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Read In Process #58

Open
LTR14 opened this issue Jun 26, 2023 · 0 comments
Open

Data Read In Process #58

LTR14 opened this issue Jun 26, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@LTR14
Copy link
Collaborator

LTR14 commented Jun 26, 2023

Source: (Any branch) PPUC/frontend/src/data/[filename].json
Source: (Any branch) PPUC/PxPUC/static/app/contracts_txt

Description: For most of the map functionalities as well as a lot of the other data sources used in searching, the data is hardcoded in these json files. The contracts being read and used in most of the website are also manually put into the second source path which are then parsed during the setup script and broken into sentences, locations, etc.

Solution: This would ideally be moved to the mastersheet file to keep everything centralized. Currently, the read-in-spreadsheet branch uses the mastersheet for a few models and is closer to the ideal solution than other branches, but most of the site there too is hardcoded. See https://docs.google.com/presentation/d/1zLYKVh1x9FClBBR48DPjraotNEX04uCR/edit?usp=sharing&ouid=111268317828128026813&rtpof=true&sd=true

@LTR14 LTR14 added the documentation Improvements or additions to documentation label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant