-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support regions/annotations #80
Comments
Doing this for regions is essential. For annotations, this would be nice, but for a small number of sources, it's not difficult to overlay one's own annotations in any basic image software. |
we would need the abilities to
|
@kswang1029, @confluence : |
The most critical part is missing: how region fits in the current architecture? Does it belong to session or image or else? If it belongs to session, how it interacts with image? If it belongs to image, how it interacts with session? How do we handle matched images? And how do we handle region analytics which requires a user-input image and a user-input region? |
There should be a new Functions for manipulating (or deleting) existing ("open") regions would be methods on this class. Whether the functions for creating / importing them should be on the session or the image class depends on the relationship between images and regions. Does each region "belong" to a specific image? If yes, then these methods should be on the image class (but call different class methods on the region class; similar to the relationship between session and image). But we might want helper methods on the session class for finding / interacting with all the regions in the session. Most of the actual region logic should be inside the region class. The methods on the image and/or session should just connect this functionality to particular images or sessions. I think that it would be helpful to start by sketching a diagram showing how images and regions are related to each other (images to regions, regions to regions, etc.). |
OK, I haven't thought that deeply but just want to add some basic functions first. I will think more about it and discuss with you few days later. |
For the publication purpose, we need to support region/annotation file loading so users can use it to decorate their images for presentation (such as an arrow plus a text to point to a target source or a set of point markers to mark target sources, etc)
once CARTAvis/carta-frontend#2019 and CARTAvis/carta-backend#1229 are merged annotation region will be supported.
The text was updated successfully, but these errors were encountered: