Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page dedicated to cb's clubs #5

Open
phynxinferno opened this issue Apr 18, 2023 · 3 comments
Open

Page dedicated to cb's clubs #5

phynxinferno opened this issue Apr 18, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@phynxinferno
Copy link
Contributor

No description provided.

@phynxinferno phynxinferno converted this from a draft issue Apr 18, 2023
@phynxinferno phynxinferno added the enhancement New feature or request label Apr 18, 2023
@AL-thecow AL-thecow added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Apr 18, 2023
@gecotron
Copy link
Contributor

For this, @AL-thecow, do you think you would be able to incorporate the desktop and mobile css sheets along with the club css? it would reduce the size of the club css sheet and allow better mobile responsiveness on the clubs page

@AL-thecow
Copy link
Collaborator

I'm confused, how would this add to the mobile responsiveness?

@gecotron
Copy link
Contributor

gecotron commented May 1, 2023

Currently we have 2 stylesheets that are selected based on the device that a quick JavaScript query detects. It is more functional & accurate than getting the CSS to switch based on pixel width, since phones have more pixels than they used to. By using an entirely separate stylesheet for the club page, it is not as responsive as the rest of the website.

Keeping the CSS for the club boxes in a separate stylesheet is a good idea, but I think it should only contain whats needed for the boxes, with everything else left to the already existing stylesheets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

3 participants