Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: change the behaviour of the filter dropdown #143

Open
bunekcca opened this issue Mar 29, 2019 · 2 comments
Open

UX: change the behaviour of the filter dropdown #143

bunekcca opened this issue Mar 29, 2019 · 2 comments

Comments

@bunekcca
Copy link
Collaborator

When a user select a value in the dropdown and he wants to select one more value, he can't. He has to reset the filters to be able to select multiple values
image

Once a value is selected, the rest of the list should still appear to make multiselection available.

@jraddaoui
Copy link
Collaborator

Hi @bunekcca,

This is a reason and a consequence of my questions in point 1 at #91 (comment). With the current implementation, after selecting a format, only that format is present in the results and the Elasticsearch aggregations applied over the results don't see the other formats.

This could be changed by using a post_filter instead of a query to filter the results, which will allow the aggregation to see all the formats. But, we have another filter in the search page, placed in there to not show files from DIPs that failed on the import process to some user types, and we don't want the formats from those files included in the filter options. Therefore the process should be:

  • Add query to remove "failed" files from the results and aggregations (based on user type).
  • Add aggregations to get all formats and collections except the ones from the "failed" files.
  • Add post_filter to remove files from the results based on applied filters.

Now, my question is, where should we apply the text query and the date range? If we apply them in the post_filter you will be able to see other formats and collections not present in the current results, but if you select one of them, they results won't change until you remove the text query or date range. So, in my opinion, this two filter should be added to the query.

Sorry for the long explanation, I hope it's clear enough to get your decision on how this should behave. If you decide to change the current behavior, it may take 6-8 hours to develop the changes.

Best regards.

@bunekcca
Copy link
Collaborator Author

Hi @jraddaoui

Thanks for the explanations. I would follow your lead on that.
But regarding the time required, we can keep it for the end of Phase 2 if there's budget remaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants