-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to pass optional WebGLRendererParameters #3
Comments
I've (finally) added this ability, I think. Could you give it a go and see if it solves your issue? |
Thanks so much for adding this, and the other stuff with file format/lattice vector support. In terms of the ability to pass I did however, run into another issue which I can't quite understand. When loading files using the Lines 934 to 936 in 4c69eec
I added logging in both places and got the following for Galaxy: Object { _arrays: {…}, _N: 8, _pbc: (3) […], _inv_cell: (3) […], _cell: (3) […], info: {} }
_N: 8
_arrays: Object { symbols: (8) […], numbers: (8) […], positions: (8) […] }
_cell: Array(3) [ (3) […], (3) […], (3) […] ]
_inv_cell: Array(3) [ (3) […], (3) […], (3) […] ]
_pbc: Array(3) [ true, true, true ]
info: Object { }
<prototype>: Object { length: length(), set_array: set_array(e, t), get_array: get_array(e)
, … }
get_array: function get_array(e)
get_atomic_numbers: function get_atomic_numbers()
get_cell: function get_cell()
get_chemical_symbols: function get_chemical_symbols()
get_inv_cell: function get_inv_cell()
get_pbc: function get_pbc()
get_positions: function get_positions()
get_scaled_positions: function get_scaled_positions()
length: function length()
set_array: function set_array(e, t)
<prototype>: Object { … } And the following for the demo: Object { _arrays: {…}, _N: 8, _pbc: (3) […], _inv_cell: (3) […], _cell: (3) […], info: {} }
_N: 8
_arrays: Object { symbols: (8) […], numbers: (8) […], positions: (8) […] }
_cell: Array(3) [ (3) […], (3) […], (3) […] ]
_inv_cell: Array(3) [ (3) […], (3) […], (3) […] ]
_pbc: Array(3) [ true, true, true ]
info: Object { }
<prototype>: Object { length: length(), set_array: set_array(name280, arr), get_array: get_array(name280)
, … }
get_array: function get_array(name280)
get_atomic_numbers: function get_atomic_numbers()
get_cell: function get_cell()
get_chemical_symbols: function get_chemical_symbols()
get_inv_cell: function get_inv_cell()
get_pbc: function get_pbc()
get_positions: function get_positions()
get_scaled_positions: function get_scaled_positions()
length: function length()
set_array: function set_array(name280, arr)
<prototype>: Object { … } I do not understand why it's failing the Do you have any insight as to what might be going wrong? It's been a while since I've done js in earnest and getting Galaxy set up to use the local |
By default the WebGLRenderer is called with no arguments:
crystvis-js/lib/render.js
Line 46 in 16445f5
It would be good to have the option to pass
WebGLRendererParameters
to this function (via the constructor forRenderer
andCrystvis
). Specifically, to integrate with the existing screenshot functionality within muon-spectroscopy-computational-project/muon-galaxy#12,preserveDrawingBuffer
would need to be set to true, which is not currently possible.The text was updated successfully, but these errors were encountered: