generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates to deploy-dev.yml to save all workflow artifacts including do… #400
Closed
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
2a26931
updates to deploy-dev.yml to save all workflow artifacts including do…
4a2a048
container registry log in for the depoloy-dev.yml
5f283fa
update to deploy-dev.yml to include docker-build with statement and m…
94610b7
update with variable to reportvision-dockerbuild
7847ed7
comment out download all workflow section
e27c39a
add upload and download of artifacts to deploy-dev.yml file
b02824d
updates to download artifacts to resove build error
deeedc6
update the deploy-dev.yml upload docker build artifact section
0b99199
delete duplicate Download Docker Artifact name
a1efad8
fix deploy OCR build failure
58d7cce
revert prior changes
5c067c1
comment out redudant downlad docker artifact code
ff6f879
add a check to make sure docker file is uploaded to path
c54bd35
update upload docker file path
47d9344
debug downloaded artifact error
0f42469
debug docker_inspect command
f3a729c
clean up code and change download artifact path and image_check logic
f99581e
add notes to refactor
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the goal here to provide access to the docker image after it's been built? If so we are pushing our images once they're built to https://github.com/CDCgov/ReportVision/pkgs/container/reportvision-ocr-api and we are doing this at
.github/actions/build-publish-api
. Once that image is published to the GH registry, theazure/webapps-deploy@v3
action uses it here:ReportVision/.github/actions/deploy-api/action.yml
Line 28 in f9eb032
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something we could possibly think of doing is migrating our registry to something like ACR instead. The main con however to doing that would be if this system ever needs to be cloud agnostic in the future, which it most likely would need to be.