Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenter broken on main #108

Closed
seabbs opened this issue Mar 1, 2024 · 4 comments · Fixed by #113
Closed

Documenter broken on main #108

seabbs opened this issue Mar 1, 2024 · 4 comments · Fixed by #113
Labels
bug Something isn't working

Comments

@seabbs
Copy link
Collaborator

seabbs commented Mar 1, 2024

See

https://github.com/CDCgov/Rt-without-renewal/actions/workflows/document-EpiAware.yaml

I'm not clear if this was picked up before merging or how this slipped through but Documenter has been broken by merging the template PR I think (i.e #104)

@seabbs seabbs added the bug Something isn't working label Mar 1, 2024
@seabbs
Copy link
Collaborator Author

seabbs commented Mar 5, 2024

I think perhaps we should make a second PR and remove much of the automated template functionality as it seems to work poorly. Instead I think we should agree some simple documentation standards (or just point out to the sciml ones with a small summary in our docs.

@SamuelBrand1
Copy link
Collaborator

Agreed. Maybe we should raise an issue with Documenter too?

@SamuelBrand1
Copy link
Collaborator

+1 to point to SciML

@SamuelBrand1
Copy link
Collaborator

Do you want me to look at this too @seabbs ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants