Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stochastic failure is negative binomial which is an epiaware issue. Aside from updating the name this is good to go. #242

Closed
SamuelBrand1 opened this issue May 29, 2024 · 3 comments
Labels

Comments

@SamuelBrand1
Copy link
Collaborator

          Stochastic failure is negative binomial which is an epiaware issue. Aside from updating the name this is good to go.

Originally posted by @seabbs in #236 (comment)

@SamuelBrand1 SamuelBrand1 added bug Something isn't working EpiAware and removed bug Something isn't working labels May 29, 2024
@seabbs
Copy link
Collaborator

seabbs commented Jun 11, 2024

@SamuelBrand1 can you refine this issue a bit so someone else (i.e. not me or you) could target it?

@SamuelBrand1
Copy link
Collaborator Author

Yeah, the stochastic failure was here.

In the other similar tests we use something with a p value that means that conditional on the test being correct stochastic failure is very rare; this unit test probably want to go that way (unless there is an argument that we will get too many false passes).

@seabbs
Copy link
Collaborator

seabbs commented Jun 28, 2024

I'm going to close as this has resolved but we still need better integration testing (but I think that should be its own issue)

@seabbs seabbs closed this as completed Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants