Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract type for simulating cases #294

Closed
SamuelBrand1 opened this issue Jun 18, 2024 · 2 comments
Closed

Abstract type for simulating cases #294

SamuelBrand1 opened this issue Jun 18, 2024 · 2 comments
Labels
enhancement New feature or request EpiAware

Comments

@SamuelBrand1
Copy link
Collaborator

Currently generating data, e.g. using data = missing patterns returns a Vector{Union{Missing, Real}} type object. This is known to be poorly performant because Real is an abstract type ( https://docs.julialang.org/en/v1/manual/performance-tips/#man-performance-abstract-container ).

This is not a priority issue, but worth flagging. A potential fix would probably involve the model looking at its error model, and making type specification e.g. PoissonError would specify a concrete integer type. That would be slightly awkward at the moment.

@SamuelBrand1 SamuelBrand1 added enhancement New feature or request EpiAware labels Jun 18, 2024
@seabbs
Copy link
Collaborator

seabbs commented Jul 25, 2024

Could you flesh this out a bit please sam? In particular what the performance implications are (given for most performance critical things you are passing data?)

@SamuelBrand1
Copy link
Collaborator Author

We no longer do this so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request EpiAware
Projects
None yet
Development

No branches or pull requests

2 participants