Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git ignore manifest.toml #32

Closed
seabbs opened this issue Feb 12, 2024 · 2 comments · Fixed by #36
Closed

git ignore manifest.toml #32

seabbs opened this issue Feb 12, 2024 · 2 comments · Fixed by #36
Labels
at-release EpiAware
Milestone
EpiAware 0.1.0

Comments

@seabbs
Copy link
Collaborator

seabbs commented Feb 12, 2024

When EpiAware is stable community posts suggest that good practice is to depend on the Package.toml and to therefore .gitignore the manifest. This is also helpful as it avoids frequent merge issues during development due to differing package versions etc.
@SamuelBrand1
Copy link
Collaborator

Agreed.

@seabbs
Copy link
Collaborator Author

seabbs commented Feb 13, 2024

Due you have a read on when we should do this? I almost think it should be sooner rather than later?

@seabbs seabbs mentioned this issue Feb 13, 2024
Merged
@seabbs seabbs linked a pull request Feb 13, 2024 that will close this issue
Issue 32: First remove Manifest.toml and gitignore #36
Merged
@seabbs seabbs mentioned this issue Feb 13, 2024
Closed
@seabbs seabbs added this to the EpiAware 0.1.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
at-release EpiAware
Projects
None yet
Milestone
EpiAware 0.1.0
Development

Successfully merging a pull request may close this issue.

Issue 32: First remove Manifest.toml and gitignore CDCgov/Rt-without-renewal
2 participants
@seabbs @SamuelBrand1