Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand unit testing to include more NUTs based parameter recovery #368

Closed
seabbs opened this issue Jul 11, 2024 · 1 comment · Fixed by #371
Closed

Expand unit testing to include more NUTs based parameter recovery #368

seabbs opened this issue Jul 11, 2024 · 1 comment · Fixed by #371
Labels
EpiAware question Further information is requested

Comments

@seabbs
Copy link
Collaborator

seabbs commented Jul 11, 2024

Our unit testing currently covers sampling properties of all functions and our benchmarks cover the ability to calculate gradients. Potentially we might want to expand testing to see if key parameters can be recovered by NUTs (i.e simulate from the prior model and fit w/ high tolerances)?

Potentially this would give us warnings of issues but it would increase the length of our testing and could easily not add that much value (especially given the existence of gradient checks in the benchmarks).

This came up in #358

@seabbs seabbs added question Further information is requested EpiAware labels Jul 11, 2024
@SamuelBrand1 SamuelBrand1 linked a pull request Jul 15, 2024 that will close this issue
@SamuelBrand1
Copy link
Collaborator

If it is merged does #371 close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EpiAware question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants