Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming step functions to iteration or update functions? #439

Open
SamuelBrand1 opened this issue Aug 28, 2024 · 10 comments
Open

renaming step functions to iteration or update functions? #439

SamuelBrand1 opened this issue Aug 28, 2024 · 10 comments
Labels
documentation Improvements or additions to documentation EpiAware

Comments

@SamuelBrand1
Copy link
Collaborator

Minor issue, but I think us using step functions as terminology for the iteration/update steps in accumulate_scan is possibly a bit confusing? Because "step function" is a pretty well known maths concept (https://en.wikipedia.org/wiki/Step_function), and we are using it in a different context e.g. "step-by-step".

This might just be reflecting my personal biases!

@SamuelBrand1 SamuelBrand1 added documentation Improvements or additions to documentation EpiAware labels Aug 28, 2024
@SamuelBrand1
Copy link
Collaborator Author

e.g. AbstractAccumulationStep -> AbstractAccumulationUpdate

@seabbs
Copy link
Collaborator

seabbs commented Aug 28, 2024

good point. Would your suggestion be iterator or updator or other?

@SamuelBrand1
Copy link
Collaborator Author

My suggestion would be update or updater because iterator is a bit overloaded in Julia.

@seabbs
Copy link
Collaborator

seabbs commented Aug 28, 2024

so I don't think we should use update as we are likely to want a function called update to i.e update turing models (and in my head update means update an existing object). I don't love that it doesn't clearly identify the iterative process. Hmm

@SamuelBrand1
Copy link
Collaborator Author

Some thing with recurrence or recurrent or an abbreviation?

@seabbs
Copy link
Collaborator

seabbs commented Aug 28, 2024

hmm maybe

@SamuelBrand1
Copy link
Collaborator Author

Its the same operation as a recurrent NN (just with a dot product rather than a NN call)... so at least some people would find it intuitive description.

@seabbs
Copy link
Collaborator

seabbs commented Aug 29, 2024

good point

@SamuelBrand1
Copy link
Collaborator Author

Have we in fact just settled on Steps?

@seabbs
Copy link
Collaborator

seabbs commented Dec 13, 2024

I think we have more paused thinking about it until we have a better vision for a more generic composable iterator vision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation EpiAware
Projects
None yet
Development

No branches or pull requests

2 participants