Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Abstract**Process to Abstract**Model for consistency? #88

Closed
seabbs opened this issue Feb 28, 2024 · 7 comments · Fixed by #89
Closed

Rename Abstract**Process to Abstract**Model for consistency? #88

seabbs opened this issue Feb 28, 2024 · 7 comments · Fixed by #89
Assignees
@seabbs
Labels
EpiAware
Milestone
EpiAware 0.1.0

Comments

@seabbs
Copy link
Collaborator

seabbs commented Feb 28, 2024

As the title
@SamuelBrand1
Copy link
Collaborator

Actually I was wondering about this process vs model naming business... Whats our naming decision?

@seabbs
Copy link
Collaborator Author

seabbs commented Feb 28, 2024

I think we don't have one but we should standardise. I'm open to either

@SamuelBrand1
Copy link
Collaborator

Its close to a coin flip, but I'd go for Model as the postfix.

  • Slightly shorter.
  • A model includes the idea of a process; and not all our models are necessarily processes.

@seabbs
Copy link
Collaborator Author

seabbs commented Feb 28, 2024 •
edited
Loading

yes both good points. updating the title. I thought I would tackle this along with #86

@seabbs seabbs changed the title Rename AbstractEpiModel to AbstractEpiProcess for consistency? Rename Abstract**Model to Abstract**Process for consistency? Feb 28, 2024
@seabbs seabbs self-assigned this Feb 28, 2024
@seabbs
Copy link
Collaborator Author

seabbs commented Feb 28, 2024

Do we think this extends to all uses of process? For example generate_latent_process?

@seabbs
Copy link
Collaborator Author

seabbs commented Feb 28, 2024

I'm thinking yes

@SamuelBrand1
Copy link
Collaborator

I think yes, we might as well be consistent and make it like the user doesn't need to guess (whilst still being readable)

@seabbs seabbs mentioned this issue Feb 28, 2024
Merged
@seabbs seabbs changed the title Rename Abstract**Model to Abstract**Process for consistency? Rename Abstract**Process to Abstract**Model for consistency? Feb 29, 2024
@seabbs seabbs added this to the EpiAware 0.1.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seabbs seabbs

Labels
EpiAware
Projects
None yet
Milestone
EpiAware 0.1.0
2 participants
@seabbs @SamuelBrand1