Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should diagnostic thresholds be exposed in the config #53

Open
zsusswein opened this issue Oct 2, 2024 · 1 comment
Open

Should diagnostic thresholds be exposed in the config #53

zsusswein opened this issue Oct 2, 2024 · 1 comment
Labels

Comments

@zsusswein
Copy link
Collaborator

Or hardcoded in the diagnostic processing. It's easy to expose them, so probably better to just do it?

But we don't really touch them and arguably we'd want to be pretty deliberate about changes, which is an argument for leaving them somewhat buried.

Originally came up in @athowes review on #41.

cc: @kgostic @natemcintosh

@natemcintosh
Copy link
Collaborator

Yea, I could see both ways being good. Personally, I have a slight preference for putting them in the config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants