Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI for closing filter boxes in eCR Library #2995

Open
4 tasks
angelathe opened this issue Dec 5, 2024 · 0 comments · May be fixed by #3084
Open
4 tasks

Update UI for closing filter boxes in eCR Library #2995

angelathe opened this issue Dec 5, 2024 · 0 comments · May be fixed by #3084
Assignees
Labels
needs design review The PR for this issue will need design review before merging Streamline eCR Issues for Streamline eCR team to work on

Comments

@angelathe
Copy link
Collaborator

angelathe commented Dec 5, 2024

What needs to be done

Update the UI for closing filter boxes in the eCR Library, such that:

GIVEN that a filter box is open
WHEN a user clicks off the box (anywhere but the filter box) or clicks a different filter box
THEN the current filter box closes automatically.

Why it needs to be done

Currently, when a filter box is open, a user must click the filter button directly to close the box. This is not ideal for accessibility purposes.

Design review

Link to Figma design in Dev mode
Link to Figma prototype

Acceptance Criteria

  • Given an open filter box, it should close if a user clicks anywhere outside of the box
  • Given an open filter box, it should close if the user hits the esc key
  • Only one filter box should open at a time.
    - For example, if the user clicks on condition, the condition box will open. Then, if they clicked on the date filter button, the condition box would automatically close and the filter by date box would open.
    - If a filter box is open and the reset button is clicked, then the filter box should close automatically.
  • Unit tests have been added

Technical Notes

Relevant files:

  • src/app/components/Filters.tsx
@angelathe angelathe added Streamline eCR Issues for Streamline eCR team to work on needs design review The PR for this issue will need design review before merging labels Dec 5, 2024
@mcmcgrath13 mcmcgrath13 self-assigned this Dec 23, 2024
@mcmcgrath13 mcmcgrath13 linked a pull request Dec 23, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs design review The PR for this issue will need design review before merging Streamline eCR Issues for Streamline eCR team to work on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants