From ea857731dea5e47f99227bc101ed2cbb1e1ebb74 Mon Sep 17 00:00:00 2001 From: "George G. Vega Yon" Date: Wed, 23 Oct 2024 14:53:28 -0600 Subject: [PATCH] Replacing artifact and setting retention days to 7 (#230) --- .github/workflows/pkgdown.yaml | 40 +++++++++++++++------------------- NEWS.md | 5 ++++- 2 files changed, 21 insertions(+), 24 deletions(-) diff --git a/.github/workflows/pkgdown.yaml b/.github/workflows/pkgdown.yaml index 5c532a5c..862f3750 100644 --- a/.github/workflows/pkgdown.yaml +++ b/.github/workflows/pkgdown.yaml @@ -171,6 +171,8 @@ jobs: uses: actions/upload-pages-artifact@v3 with: path: ./docs/ + name: github-pages + retention-days: 7 deploy: # check builds on PRs but only deploy when main changes @@ -190,31 +192,23 @@ jobs: uses: actions/deploy-pages@v4 post-page-artifact: - # only comment on PRs + runs-on: ubuntu-latest + if: ${{ github.event_name == 'pull_request' }} + + # This job depends on the `build` job needs: combine - runs-on: ubuntu-latest + + # Required permissions permissions: - contents: read - pull-requests: write - env: - GH_TOKEN: ${{ github.token }} - steps: - - name: Checkout - uses: actions/checkout@v4 - - name: Find Comment - uses: peter-evans/find-comment@v3 - id: fc - with: - issue-number: ${{ github.event.pull_request.number }} - comment-author: 'github-actions[bot]' - body-includes: Your page is ready to preview + contents: read + pull-requests: write - - name: Create or update comment - uses: peter-evans/create-or-update-comment@v4 + steps: + # Post the artifact pulling the id from the `readme` step. + # The msg will refer to the arfitact as 'README file'. + - name: Post the artifact + uses: CDCgov/cfa-actions/post-artifact@v1.0.0 with: - comment-id: ${{ steps.fc.outputs.comment-id }} - issue-number: ${{ github.event.pull_request.number }} - body: | - Thank you for your contribution, @${{ github.triggering_actor }} :rocket:! Your page is ready to preview [here](https://github.com/${{github.repository}}/actions/runs/${{ github.run_id }}/artifacts/${{ needs.build.outputs.page_artifact_id }}) - edit-mode: replace + artifact-name: github-pages + gh-token: ${{ secrets.GITHUB_TOKEN }} diff --git a/NEWS.md b/NEWS.md index c4128d94..4f1c70fc 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,8 @@ -# wwinference dev +# wwinference 0.1.0.99 (dev) +## Internal changes + +- Updated the workflow for posting the pages artifact to PRs (issue [#229](https://github.com/CDCgov/ww-inference-model/issues/229)). - Modify `plot_forecasted_counts()` so that it does not require an evaluation dataset ([#218](https://github.com/CDCgov/ww-inference-model/pull/218)) # wwinference 0.1.0