You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All of the projects in the family (mquery frontend, mquery backend, ursadb) make a heavy use of autoformatters (prettier, black, clang-format). This issue is about the first two.
We use prettier with an unstandard --tab-width=4 option.
We use black with unstandard line-length=79 configuration.
I'll take a hit on this one - if I remember correctly they were both my personal preference at the time (still is). But now I also see any bit of additional unstandard configuration as a liability and a hoop for new contributors to jump over.
Describe the solution you'd like
I propose to revert this configuration and use the defaults from now on.
We should also:
reformat the repo with new configuration
fix the documentation
Describe alternatives you've considered
The downside of reformatting everything is that we will lose some of the git blame magic. Alternative approach is to transparently rewrite git history - but I'm strongly against it, because this will completely devastate all the forks (for example, people that run mquery with one or two custom modifications).
We can also leave the formatter settings unchanged. This issue was created to discuss this problem and it's not decided if we're going to do this.
The text was updated successfully, but these errors were encountered:
I think reverting to default settings is a good idea. Indeed, it will ruin git history but not many people worked on mquery so far so it's not hard to find who to blame :)
Feature Category
Describe the problem
All of the projects in the family (mquery frontend, mquery backend, ursadb) make a heavy use of autoformatters (prettier, black, clang-format). This issue is about the first two.
--tab-width=4
option.line-length=79
configuration.I'll take a hit on this one - if I remember correctly they were both my personal preference at the time (still is). But now I also see any bit of additional unstandard configuration as a liability and a hoop for new contributors to jump over.
Describe the solution you'd like
I propose to revert this configuration and use the defaults from now on.
We should also:
Describe alternatives you've considered
The downside of reformatting everything is that we will lose some of the
git blame
magic. Alternative approach is to transparently rewrite git history - but I'm strongly against it, because this will completely devastate all the forks (for example, people that run mquery with one or two custom modifications).We can also leave the formatter settings unchanged. This issue was created to discuss this problem and it's not decided if we're going to do this.
The text was updated successfully, but these errors were encountered: