Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop: share_queried_objects capability #1004

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Dec 12, 2024

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

share_queried_objects was a very obscure feature that allow certain users to access any sample in the system if they know a direct link to the specific object. It was never used in mwdb.cert.pl and is not very well supported e.g. you can't reach these sample via search by providing a hash.

What is the new behaviour?

This PR removes support for share_queried_objects capability.

Also removed DeprecatedFeature that I forgot to remove in #1003

@psrok1 psrok1 marked this pull request as ready for review December 12, 2024 14:18
@psrok1 psrok1 merged commit ebb5f21 into v3.0.x Dec 12, 2024
12 checks passed
@psrok1 psrok1 deleted the drop/share-queried-objects branch December 12, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant