Don't load filtered-out parents eagerly on every Object.access #997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
[ ] I've added automated tests for my change (if applicable, optional)(already covered)[ ] I've updated documentation to reflect my change (if applicable)(no changes)What is the current behaviour?
There is definitely too much magic there that is quite ineffective. When object has lots of parents, every
Object.access()
that is called in almost every object endpoint will eagerly load all parents and all its tags even if they're not used by the endpoint.What is the new behaviour?
Replaced eager loading with property
accessible_parents
that makes a query when requested. It is then called by proper schema fields.Other functions that are relying on user's view of parents are already using dedicated query instead of
object.parents
direct relationship access (e.g. search additionally filters out objects usingg.auth_user.has_access_to_object
)Test plan
Security checks covered by automated tests. Performed manual check if everything works properly.
Closing issues