Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token APIs have confusing names #319

Open
davidchisnall opened this issue Oct 18, 2024 · 1 comment
Open

Token APIs have confusing names #319

davidchisnall opened this issue Oct 18, 2024 · 1 comment

Comments

@davidchisnall
Copy link
Collaborator

A bunch of the APIs have obj in the middle, which violates our 'no abbreviations' policy. I'm not convinced that 'token' is actually the right name for this at all (bikeshedding welcome).

We can probably also remove token_sealed_unsealed_alloc. This has to return one result indirectly and so introduces some pain in the ABI. It was added because token_obj_unseal was a second cross-compartment call, but now it is a (fast) call into the token library and so it may be simpler to just return the sealed object and rely on the caller to unseal it.

@nwf
Copy link
Member

nwf commented Oct 18, 2024

Whatever names we end up with, we should probably also rename SKeyStruct/SObjStruct/SKey/SObj.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants