Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channels is now on 3.x #29

Closed
ShaheedHaque opened this issue Dec 7, 2020 · 4 comments
Closed

Channels is now on 3.x #29

ShaheedHaque opened this issue Dec 7, 2020 · 4 comments

Comments

@ShaheedHaque
Copy link

With the release of Channels 3.x, and the changes to/coming in pip, I'm seeing this during installs:

ERROR: After October 2020 you may experience errors when installing or updating packages. This is because pip will change the way that it resolves dependency conflicts.

We recommend you use --use-feature=2020-resolver to test your packages with the new resolver before it becomes the default.

channels-rabbitmq 1.2.1 requires channels~=2.2, but you'll have channels 3.0.2 which is incompatible.

Any chance of an updated release before pip starts breaking would be most welcome :-).

@adamhooper
Copy link
Contributor

Thanks for the ping. I'll take a look.

@adamhooper
Copy link
Contributor

A status update: since Channels 3.0 is a major version update, I'm going to make the channels_rabbitmq change a major version update, too. And since I don't want to force two major-version updates, I'm being patient.

Since Channels 3.0 is a major version bump, I'm bumping msgpack, too. And I'm investigating aiormq. aioamqp hasn't been released in over a year, and its pamqp dependency is obsolete. (Also, its penchant to hang by default gives me the willies. Apart from channels_rabbitmq, I find it hard to write clean reconnect code that also works well in unit tests.)

I've submitted mosquito/aiormq#102 to aiormq to support SSL contexts. Once it lands, I'll test it out with channels_rabbitmq.

@ShaheedHaque
Copy link
Author

Sounds like a good plan.

@adamhooper
Copy link
Contributor

I got impatient :). I released v1.3.0 today, with Channels 3 support and not much else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants