Check for duplicate directional links #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly resolves #108, although skeleton links with highway project coding that contradicts link's DIRECTIONS attribute could slip through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly resolves #108, where links with unique ABB values could still result in duplicate directional links being generated by the Generate Highway Files tool. For example, two links with ABB values
10001-10002-1and10002-10001-1could both exist in the MHN withDIRECTIONS='2'. Generate Highway Files would then generate directional links10001-10002and10002-10001twice each, and during the batchin process Emme would only import one of each.This PR adds code to the Incorporate Edits tool to identify any such duplicates, based on every link's ANODE, BNODE and DIRECTIONS values.