-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update failing MacPorts build instructions #64
Comments
With latest Xcode installed via CLI and GUI, currently receive:
main.log contents:
|
Leon Stafford wrote on Wed, Feb 24, 2021 at 05:38:46PM -0800:
---> Attempting to fetch edbrowse-3.4.10_4.darwin_20.x86_64.tbz2 from
https://mse.uk.packages.macports.org/edbrowse
3.4.10 is over 7 years old, the first thing to try would be to attempt
an update (currently 3.7.7)
(the errors far below refer to undefined function that has long been
removed - it's possible an update will have other issues but at least
not the same ones)
…--
Dominique
|
Thanks @martinetd! Looks like I'll be able to submit to the MacPorts repo with updated build instructions, so will try to build outside of ports first with latest head and if successful, will send patch to MacPorts build instructions. |
Was able to build from source on macOS, using:
Which gave me a functional |
Looking at section on how to test Portfile locally |
Setup a local port tree, copied over current MacPorts Modified to use this repo to fetch release, like:
This pulls correctly, but then fails on the patches, which are likely very out of sync, if still needed at all. Will keep digging |
Looking better now, after commenting out the patchfile line in the
Some notes on that in edbrowse's build instructions, so will check those |
Adding |
Duktape not available as a port, so cannot use same method as tidy. Following the edbrowse guide to installing duktape:
Still failed to find it, so may need a way to specify its path |
The error log at this point:
|
@martinetd I'm stuck here. Could you please point me in right direction to get the |
@martinetd - nevermind, I see similar comment here and will dig further |
Leon Stafford wrote on Wed, Feb 24, 2021 at 08:55:43PM -0800:
Following the edbrowse guide to installing duktape:
```
git clone https://github.com/svaarala/duktape.git
cd duktape
# build the version for distribution, without all the debugging features
make dist
make dist/source
cd dist/source
make -f Makefile.sharedlibrary
make -f Makefile.sharedlibrary install (as root)
make -f Makefile.cmdline
ln -s `pwd`/duk /usr/local/bin/duk (as root)
you may have to run ldconfig to access this new library.
```
Still failed to find it, so may need a way to specify its path
`/usr/local/bin/duk` or specifically, where it can find the header
file...
I'm still not familiar with how mac users do stuff (with either ports or
brew), but I doubt a port recipe will allow you to install things to
system directories (e.g. /usr/local) ; they likely have their own tree
in their own packages.
From there in my opinion you have two paths forward:
- properly install duktape's shared library and header files as a
separate port, and ask for its inclusion together with duktape's update
- build duktape locally within edbrowse's build phase but instead of
installing it only use it locally (for example build statically and copy
header+.a to edbrowse build dir)
Both are probably about the same amount of work, but the first one is
probably cleaner overall so I would recommend that (although if you
already use brew and brew has a duktape package as you suggest it's
probably simpler for you to make an edbrowse brew instead of trying the
port; but there might be other reasons for this)
Either way, hang in there, it doesn't look too far.
|
putting duktape's 2 x headers in MacPorts' |
Thanks @martinetd - fumbling my way along. MacPort of I'll take a break, then aim to:
And at some point.... learn how to code in C/C++ :D |
@leonstafford did you get this to work? Always happy to help if you get stuck again. |
Thanks @martinetd! Last left it at point that I’m building local duktape (IIRC) port, then can submit that. Shifted focus to another project at moment, but want to come back to this. If you want to get it sorted faster, just including the duktape dist files (2 x headers, 1x src) and build within edbrowse, that seems fastest, but less flexible. |
No hurry here, just wanted to make sure things are ok.
Submitting a separate package for duktape looks like the way to go.
|
Howdy, while doing some housekeeping for MacPorts' |
Thanks @chrstphrchvz! Sorry, I've been on the road for a week, playing catchup with AllTheThings :) |
This issue can be closed. I've updated edbrowse in MacPorts to 3.8.2.1.
duktape is in MacPorts now but edbrowse now uses a custom version of quickjs instead of duktape. |
as mentioned in #31 and shown in failing build status on the edbrowse/builds macports page.
I'll comment with my attempts/progress and look into how MacPorts works (no experience yet).
The text was updated successfully, but these errors were encountered: