Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup errors (and suggested improvements) #2

Open
tpmccauley opened this issue Oct 17, 2019 · 1 comment
Open

setup errors (and suggested improvements) #2

tpmccauley opened this issue Oct 17, 2019 · 1 comment

Comments

@tpmccauley
Copy link

I encountered a few issues when setting up things (Ubuntu 18.10 with conda 4.7.12 and python 3.7.4 ). Since they all relate I am raising them in this one issue.

  1. After conda create --name pyrk there were several issues with package versions when running pip install -r env.pip after running conda activate pyrk. It turns out that in pyrk python 2.7 was being used from /usr/bin/python rather than python 3.7 from anaconda. It would probably be better to change the env creation command to conda create --name pyrk python=3.7 (or suitable python 3.X) to avoid this problem.

  2. Since the assumption is that we are already in a conda env perhaps it's best to rm conda==4.5.12 from env.pip? Otherwise there is a version error anyway.

  3. The coffea install in env.pip -e git+https://github.com/CoffeaTeam/coffea.git@da7d16002148a77e5dc05d8fe994e15c5a92b21c#egg=coffea fails due to a ModuleNotFoundError, not finding six. This is caused by six not actually being installed yet. It is only really installed when the pip command is successfully completed, which it isn't due to the coffea install error. I had to comment out the coffea line, run pip install -r env.pip once, then uncomment and run again.

  4. I had to rm the explicit subdirectory in the coffea install line

  5. Speaking of coffea, it looks like coffea is already included as a submodule. Perhaps better to just install it using pip like everything else?

@mverzett
Copy link

Hi @tpmccauley,

Sorry for the long silence, I stopped developing pyrk for a while, I might resume now, but we are not sure which option will be the final one. Some answers:

  1. Sure, makes sense, even though I think you might have installed the conda2 which defaults to python2, using miniconda3 it defaults to python 3, but I agree that more safety is better
  2. yeah, agreed
  3. I will try shuffling the pip packages
  4. I do not understand what you changed, can you be more specific?
  5. I'd rather stay with the submodule, there is a good chance that we might have to hack into coffea to add some utilities we need, having it as a submodule makes everything easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants