Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matched sound_settings.js to match project one's file #30

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Conversation

Seckhen
Copy link

@Seckhen Seckhen commented Sep 22, 2024

Imported the changes that I made during project one to this project. Thereby satisfying the first task in project 2B.

This does not have an issue, since this was for project 1.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10982484697

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 82.688%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 10982372198: -0.005%
Covered Lines: 22342
Relevant Lines: 25596

💛 - Coveralls

@Seckhen Seckhen merged commit e4bbc68 into f24 Sep 22, 2024
1 check passed
@Seckhen Seckhen added the enhancement New feature or request label Sep 26, 2024
@Seckhen Seckhen added this to the Sprint 1 milestone Sep 26, 2024
@NickDevi NickDevi assigned NickDevi and Seckhen and unassigned NickDevi Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants