-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Team 9 Tdd 과제 제출 #10
Open
fist-99
wants to merge
15
commits into
CNU-PC-00-2022:team-9
Choose a base branch
from
fist-99:team-9
base: team-9
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Team 9 Tdd 과제 제출 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdd homework 202002523
202002553 hw2
Team 9 202002488
202002517 hw2
k-seungtae
reviewed
May 16, 2022
jest.spyOn(todoItem4, "equalsDayOfCreatedAt").mockImplementation(() => false); | ||
jest.spyOn(todoItem5, "equalsDayOfCreatedAt").mockImplementation(() => false); | ||
//2,3 번 완료 | ||
jest.spyOn(todoItem2, "completed", "get").mockImplementation(() => true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
returnValue로 함수를 넣었기 때문에, true가 아닌 함수를 반환합니다.
함수를 반환하는 것이 아니라 true로 반환을 해주어야합니다.
수정이 필요합니다.
우연히 completed가 함수를 반환하다보니, 테스트도 통과했을 것 같네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
같은 스크립트 공유 문제로 인한 사소한 대소문자 버그를 수정해서 Tdd 과제 제출합니다.