Team 8 : report #17
Open
Team 8 : report #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
team-8 201802163
team-8-201802062
remove student id path in import
remove student ID in import todoList.removeTodoItems -> todoList.removeTodoItem
team-8-201802170-hahahoho-courge-life
team-8-201802130
|
|
k-seungtae
reviewed
May 16, 2022
| }); | ||
|
|
||
| test("5개의 할 일이 있는데, 2번, 4번만 미완료다.", () => { | ||
| jest.spyOn(todoItem1, "completed", "get").mockReturnValue(() => true); |
There was a problem hiding this comment.
returnValue로 함수를 넣었기 때문에, true가 아닌 함수를 반환합니다.
함수를 반환하는 것이 아니라 true로 반환을 해주어야합니다.
수정이 필요합니다.
우연히 completed가 함수를 반환하다보니, 테스트도 통과했을 것 같네요.
modify return value in completed function
|
수정 완료했습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.