Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance status? #2

Open
cozzyd opened this issue Sep 15, 2020 · 1 comment
Open

maintenance status? #2

cozzyd opened this issue Sep 15, 2020 · 1 comment

Comments

@cozzyd
Copy link
Contributor

cozzyd commented Sep 15, 2020

Hi,

I know this says it's not maintained by the CRropa developers, but are you accepting pull requests to keep it in a working state? Right now, it's very broken (first due to the deprecation of CRPropa2 outputs, then due to the SWIG builtin issue, then due to segfaults due to improper locking and deleting auto-freed things). I've gotten it working (for me, at least) on my fork (https://github.com/cozzyd/ROOTOutputPlugin) although it looks like there is more cleanup I could do to put it into a "proer state" (e.g. to subclass everything from the Output class in crpropa3). I know responding to pull requests can be a burden though, so I understand if you just want to WONTFIX this.

Thanks,
-Cosmin

@TobiasWinchen
Copy link
Member

Sure we will accept pull requests and are in fact quite happy about them- just create one and I will look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants