Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable structural equality checks for dynamic members of type IEnumerable #20

Open
kMutagene opened this issue Feb 23, 2023 · 2 comments

Comments

@kMutagene
Copy link
Member

https://stackoverflow.com/questions/17101329/f-sequence-comparison

We might want to do structural equality check in Equals, as dynamic members having type seq<'A> will fail on comparison even when they have the same items. This might be the last improvement to enable structural equality checks for charts in Plotly.NET.

@kMutagene
Copy link
Member Author

I think this is covered by our new hash code logic @HLWeil ?

@HLWeil
Copy link
Member

HLWeil commented Dec 10, 2024

Should be, but I don't see a test case for this. So maybe we could first add that before closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants