Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework combine #43

Open
kMutagene opened this issue Dec 18, 2024 · 0 comments
Open

Rework combine #43

kMutagene opened this issue Dec 18, 2024 · 0 comments

Comments

@kMutagene
Copy link
Member

We need to find a way to perform a deep copy before combining. That way, most mutation-related issues are solved.

Continuation of #35 , which originally aimed to canonize Combine and Copy. However, these functions are slightly different from each other, and Combine needs some more work. Notably, it was possible to provide a combine function that keeps a derived type inheriting from DynamicObj. This will be lost when performing a deep copy, as that returns a boxed DynamicObj.

I think we need DeepCombine and ShallowCombine respectively, maybe some API that also helps with the subsequent unboxing, e.g. DeepCombineAs<'T>

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Dec 18, 2024
@kMutagene kMutagene moved this to Backlog in ARCStack Dec 19, 2024
@kMutagene kMutagene removed the Status: Needs Triage This item is up for investigation. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant