Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused line or make it useful. #6

Open
Ashrockzzz2003 opened this issue Oct 30, 2024 · 2 comments · May be fixed by #15
Open

Remove unused line or make it useful. #6

Ashrockzzz2003 opened this issue Oct 30, 2024 · 2 comments · May be fixed by #15
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Ashrockzzz2003
Copy link
Member

The intention of the below lines seems to be to print the error. But the errors are never printed to the console as it is within fmt.Errorf which only formats the string to error format and enclosing it with fmt.Println or a logger will only show it to the user.

fmt.Errorf(err.Error())

fmt.Errorf(err.Error())

fmt.Errorf(err.Error())

fmt.Errorf(err.Error())

Ways to resolve

  1. Remove the lines and never print the error.
  2. Add a context logger to properly log the errors.
  3. Enclose the current fmt.Errorf with fmt.Println.
@Ashrockzzz2003 Ashrockzzz2003 added bug Something isn't working good first issue Good for newcomers labels Oct 30, 2024
@Ashrockzzz2003 Ashrockzzz2003 moved this to Todo in amrita_pyq Nov 1, 2024
@IAmRiteshKoushik
Copy link
Collaborator

IAmRiteshKoushik commented Nov 15, 2024

/assign pls @Ashrockzzz2003

@Ashrockzzz2003
Copy link
Member Author

Ashrockzzz2003 commented Nov 15, 2024

Done @IAmRiteshKoushik.
Thanks for taking it up!

@Ashrockzzz2003 Ashrockzzz2003 moved this from Todo to In Progress in amrita_pyq Nov 15, 2024
@Ashrockzzz2003 Ashrockzzz2003 added this to the Improve Code Quality. milestone Nov 15, 2024
@IAmRiteshKoushik IAmRiteshKoushik linked a pull request Nov 15, 2024 that will close this issue
@Ashrockzzz2003 Ashrockzzz2003 linked a pull request Nov 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants