Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine if optional date fields should be validated #1141

Open
jdaigneau5 opened this issue Nov 6, 2023 · 2 comments
Open

Determine if optional date fields should be validated #1141

jdaigneau5 opened this issue Nov 6, 2023 · 2 comments

Comments

@jdaigneau5
Copy link
Collaborator

Summary

Currently, optional date fields such as dateAssigned and timeline dates can have values that are future dates. These fields describe events that have already happened and should be past dates. However, We don't validate every optional field. We need to determine if these fields should be validated and how.

Proposed Actions

  • Create middleware to reject containers with future dates (like datePublic)
  • Determine that Cve-Services should not validate these fields

Note
This is related to a previous AWG discussion about validated optional fields or not

@zmanion
Copy link

zmanion commented Dec 12, 2023

I accidentally submitted a future datePublic for CVE-2023-6265, noticed and fixed it. I suggest that datePublic is both useful to consumers and useful in logic to reduce errors, for example, not accepting a submission with a future datePublic might defend against a premature public disclosure.

@jdaigneau5
Copy link
Collaborator Author

I accidentally submitted a future datePublic for CVE-2023-6265, noticed and fixed it. I suggest that datePublic is both useful to consumers and useful in logic to reduce errors, for example, not accepting a submission with a future datePublic might defend against a premature public disclosure.

We currently have a change addressing datePublic specifically on Test that prevents any future datePublic values. Other optional fields (time related or otherwise) might need more discussion.

@jdaigneau5 jdaigneau5 moved this to Low Priority in Issue Triage Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Low Priority
Development

No branches or pull requests

2 participants