Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more mac address formats #228

Open
xmacan opened this issue Jun 18, 2024 · 5 comments
Open

Add more mac address formats #228

xmacan opened this issue Jun 18, 2024 · 5 comments
Assignees

Comments

@xmacan
Copy link
Member

xmacan commented Jun 18, 2024

add mac address formats:
xxxx-xxxx-xxxx
xxxx.xxxx.xxxx
xxxxxxxxxxxx

  1. change settings "Mac address delimiter" to "Mac address format"
  2. prepare function mt_format_mac
  3. use everywhere

(Cacti/cacti#5746)

@TheWitness
Copy link
Member

Maybe make the is user preference. It's already there but missing the - as an option.

@xxconn
Copy link
Contributor

xxconn commented Nov 5, 2024

xxxx-xxxx-xxxx
xxxx.xxxx.xxxx
xxxxxxxxxxxx
xx:xx:xx:xx:xx:xx

What is the format of MAC's data in the database?
If it's a user preference, it means that is the display format.

@TheWitness
Copy link
Member

The later. Those other two formats are not supported, but are only a code change away.

@xxconn
Copy link
Contributor

xxconn commented Nov 5, 2024

Add one more format:
xx-xx-xx-xx-xx-xx

@TheWitness
Copy link
Member

That format and the colon format are both supported. I think they are stored in the database with colons, but it’s honestly been so many years since I wrote it, I don’t remember 😉

@xmacan xmacan self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants