Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workplane.__add__ raises ValueError instead of returning NotImplemented #1693

Open
0xorial opened this issue Oct 29, 2024 · 1 comment
Open

Comments

@0xorial
Copy link

0xorial commented Oct 29, 2024

From python docs:

If one of those methods does not support the operation with the supplied arguments, it should return NotImplemented.

It currently just calls .union(), which leads to raising a ValueError()

@adam-urbanczyk
Copy link
Member

What is exactly the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants