Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor signature not remapped #7

Open
Johni0702 opened this issue Jan 11, 2022 · 0 comments
Open

Constructor signature not remapped #7

Johni0702 opened this issue Jan 11, 2022 · 0 comments

Comments

@Johni0702
Copy link

Or more generally, when there is no explicit MethodMapping for a method, any AT for that method will not have its descriptor remapped, even though the descriptor may contain types which do have mappings.
E.g. remapping from srg to official names:

# Input
public net.minecraft.client.resources.ResourcePackRepository$Entry <init>(Lnet/minecraft/client/resources/ResourcePackRepository;Ljava/io/File;)V # constructor
# Expected
public bnm$a <init>(Lbnm;Ljava/io/File;)V
# Actual
public bnm$a <init>(Lnet/minecraft/client/resources/ResourcePackRepository;Ljava/io/File;)V
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant