Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove redundant Task usages on separated threads
FfiRequestsPool
IFFIClient interface
disposable FFIClient
FFIClient initialize simplify
PoolableFFIClient
NativeMethods pass pointer
response pooling
tests for reject manual creation of protocol objects
FfiResponseWrap, remove manual new Request calls
remove IPoolableFFIClient
FFIBridge introduction, remove closures, RAII with FfiResponseWrap and FfiRequestWrap
Clear -> generic ClearMessage (+16 squashed commits) Squashed commits:
[768fb01] Multithread refactor (Error on the 2nd time sharing screen livekit/client-sdk-unity#13)
disconnect support
Fix name
To handle better connection and disconnection from room
change to avoid using of Coroutines, using async methods instead
async OnAudioRead
Cleaning logs
Cancel tokens
Cancel token
remove Task.Run, since usually SendRequest is called from other task
getting rid of use YieldInstruction
adding audio filter in main thread
passing CancellationToken instead of CancellationTokenSource
added check for cancellation at beginning
Cleaning handles
fix await
remove cruft
Cancellation token cleanup
Factory async method
basic handling of remaining events
more async
wip
Compile pass
formatting
fix pending check
revert async changes
prep audio filter for threads
loggin
logs to debug publishing track
minor cleanup
added some methods to handle localtrack and SetSubscribed, Clenaing code
Cleaning up
fixes for yield instructions
macro for verbose logs
Audio data and pointer fix
Still says samplerate and num of channels are incorrect
remove possibility of null
todo ref buffering
minor cleanup
cruft
todo object pooling
remove redundant Task usages on separated threads
Co-authored-by: cdga777 [email protected]
Co-authored-by: nickkhalow [email protected]
[a400ec9] enable nullables
[a5a63c4] minor cleanup
[892407a] to prevent null reference
[511ef58] Hack for now
Room Ids are different
[6456edc] Test sending data
[eca1cb5] new initialize call
[830ebd1] modification trying to fix compiler errors [496618c] Added metas.
[2cf59c3] Updated FFIClient with the correct FfiRequest class name based on updated proto file generated classes. [c8e3906] updated protobuf messages to latest to be able to publish data. [bb762d2] Updated dll
[80d3dcd] Fixed the last error regarding the leak fix [7320b31] Fixed a compile error on the distructor
[561282f] Fixed a memory leak
[db871de] Fixed building issue.