Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unset categories can't be returned by analyse #1

Open
josiemundi opened this issue Aug 4, 2020 · 4 comments
Open

unset categories can't be returned by analyse #1

josiemundi opened this issue Aug 4, 2020 · 4 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers keep-open stale

Comments

@josiemundi
Copy link
Collaborator

Describe the bug
When there is already a category 'unset' string that is the same or contains any character within another string, the analyse endpoint will not color by category.

To Reproduce
Steps to reproduce the behavior:

  1. In the highlighter, select just the letter "p" and leave it uncategorised.
  2. Highlight another word that has "p" within it (e.g "leap") and categorize it.
  3. Go to 'TakeTwo web api' text creator page and type in the second word you highlighted ("leap").
  4. See that the category color does not show.

Expected behavior
Should highlight all matches, for example both "p" and "pappa".

Additional context
We can fix this by filtering out the "unset" categories when using the analyse endpoint. TO DO.

@josiemundi josiemundi self-assigned this Aug 4, 2020
@josiemundi josiemundi added bug Something isn't working good first issue Good for newcomers labels Jun 7, 2021
@github-actions
Copy link

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed in 14 days.

@github-actions github-actions bot added the stale label Aug 17, 2021
@naagma5 naagma5 removed the stale label Nov 18, 2021
@naagma5 naagma5 reopened this Nov 18, 2021
@github-actions
Copy link

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed in 14 days.

@github-actions github-actions bot added the stale label Dec 19, 2021
@github-actions github-actions bot closed this as completed Jan 3, 2022
@demilolu demilolu reopened this Feb 3, 2022
@demilolu demilolu removed the stale label Feb 3, 2022
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed in 14 days.

@github-actions github-actions bot added the stale label Apr 6, 2022
@upkarlidder upkarlidder assigned nitekon1 and unassigned josiemundi May 5, 2022
@github-actions
Copy link

github-actions bot commented Jul 6, 2022

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed in 14 days.

@github-actions github-actions bot added the stale label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers keep-open stale
Projects
None yet
Development

No branches or pull requests

5 participants