Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching from libpcrecpp to libpcre2 #9

Open
pgrt opened this issue Nov 26, 2021 · 1 comment
Open

Switching from libpcrecpp to libpcre2 #9

pgrt opened this issue Nov 26, 2021 · 1 comment

Comments

@pgrt
Copy link

pgrt commented Nov 26, 2021

Hello,

I am the Debian packager of goby3.

As the pcre3 library, on which the C++ source files in goby3 depend, is now unmaintained upstream, I wrote the enclosed patch to switch to pcre2, which is regularly maintained by the pcre developers. See https://bugs.debian.org/1000043 for more information on the subject.

I tested the patch by compiling src/cpp/GsnapParseTest1.cc (with only testPcre() inside) and running it successfully. I did not test anything else as I do not need the C++ part of goby3 in the Debian package. Maybe you would be interested in testing it.

Best regards,

Pierre
using_pcre2.txt

@guillemj
Copy link

Hi!

I had to switch some C++ projects from PCRE to PCRE2, and initially went with something like the proposed patch, but then I realized the natural successor for the pcrecpp library (which was initially contributed by Google) is actually RE2, which has a very similar API and is a native C++ one, and the switch turns into a rather small diff. I'd recommend checking that out before considering merging the proposed patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants