Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: change function signature which is more readable #86

Open
aeharvlee opened this issue Feb 7, 2023 · 0 comments
Open

Chore: change function signature which is more readable #86

aeharvlee opened this issue Feb 7, 2023 · 0 comments

Comments

@aeharvlee
Copy link

ToAddress function returns list of address.
I think ToAddresses or ToAddressList` will be more readable.

func ToAddress(addrs []string) []common.Address {
if addrs == nil {
return make([]common.Address, 0)
}
arr := make([]common.Address, len(addrs))
for i, v := range addrs {
arr[i] = common.HexToAddress(v)
}
return arr
}

If you guys ok for this, I'll create PR for it.

dongsam pushed a commit that referenced this issue Aug 13, 2024
feat: Package bump from v7 to v8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant