Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A0-4250: Substrate v1.5.0 #1677

Merged
merged 24 commits into from
Apr 23, 2024
Merged

A0-4250: Substrate v1.5.0 #1677

merged 24 commits into from
Apr 23, 2024

Conversation

lesniak43
Copy link
Contributor

@lesniak43 lesniak43 commented Apr 9, 2024 •
edited
Loading

Description

Updating Substrate to v1.5.0

We postpone proper integration of paritytech/polkadot-sdk#1370 (this will be done before the next release).

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have bumped aleph-client version if relevant

Damian Leśniak and others added 22 commits April 9, 2024 13:59
@lesniak43 lesniak43 marked this pull request as ready for review April 22, 2024 11:26
timorleph
timorleph approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@timorleph timorleph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments but mostly looks good.

bin/node/src/service.rs Outdated Show resolved Hide resolved
finality-aleph/src/lib.rs Show resolved Hide resolved
finality-aleph/src/network/gossip/mock.rs Outdated Show resolved Hide resolved
finality-aleph/src/network/gossip/mod.rs Outdated Show resolved Hide resolved
finality-aleph/src/network/gossip/service.rs Outdated Show resolved Hide resolved
finality-aleph/src/network/mock.rs Outdated Show resolved Hide resolved
finality-aleph/src/network/substrate.rs Outdated Show resolved Hide resolved
finality-aleph/src/network/substrate.rs Outdated Show resolved Hide resolved
finality-aleph/src/network/substrate.rs Outdated Show resolved Hide resolved
finality-aleph/src/testing/network.rs Outdated Show resolved Hide resolved
kostekIV
kostekIV approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@kostekIV kostekIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bin/node/src/service.rs Outdated Show resolved Hide resolved
@lesniak43 lesniak43 added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit ff98e89 Apr 23, 2024
63 checks passed
@lesniak43 lesniak43 deleted the A0-4250-substrate-v1.5.0 branch April 23, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timorleph timorleph timorleph approved these changes

@kostekIV kostekIV kostekIV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lesniak43 @kostekIV @timorleph