Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maybe bug in prepare & load's order #598

Open
daiwk opened this issue Jul 27, 2024 · 1 comment
Open

maybe bug in prepare & load's order #598

daiwk opened this issue Jul 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@daiwk
Copy link

daiwk commented Jul 27, 2024

🐛 Describe the bug

https://github.com/CarperAI/trlx/blob/main/trlx/trlx.py#L140
this load function may be called after prepare in
https://github.com/CarperAI/trlx/blob/main/trlx/trainer/accelerate_base_trainer.py#L86
according to
https://huggingface.co/docs/accelerate/usage_guides/checkpoint

this may cause the loading not work actually, such as deepspeed model

Which trlX version are you using?

No response

Additional system and package information

No response
@daiwk daiwk added the bug Something isn't working label Jul 27, 2024
@daiwk
Copy link
Author

daiwk commented Jul 28, 2024

this commit could help in my situation
Jingru@39f1ae9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daiwk