Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window.remove should kill empty html producer #973

Open
ronag opened this issue Apr 26, 2018 · 4 comments · May be fixed by #1320
Open

window.remove should kill empty html producer #973

ronag opened this issue Apr 26, 2018 · 4 comments · May be fixed by #1320
Labels
html type/bug
Milestone
v2.3.1 LTS

Comments

@ronag
Copy link
Member

ronag commented Apr 26, 2018 •
edited
Loading

Broken window.remove implementation has been removed. Needs to be properly re-implemented.

This is mostly to save on memory usage when the HTML producer is empty and the user doesn't clear it and not leave stuff hanging in DIAG.
@ronag ronag added this to the 2.2.0 milestone Apr 26, 2018
@ronag ronag added the html label Apr 26, 2018
@ronag ronag self-assigned this Jul 17, 2018
@ronag ronag changed the title HTML doesn't clear on window.remove window.remove should kill empty html producer Jul 18, 2018
@ronag ronag assigned Julusian and unassigned ronag Jul 18, 2018
@ronag
Copy link
Member Author

ronag commented Jul 18, 2018

@Julusian maybe something for you?

@ronag ronag modified the milestones: 2.2.0, 2.3.0 Jul 19, 2018
@Julusian Julusian mentioned this issue Jul 23, 2019
Open
@dotarmin dotarmin removed this from the 2.3.0 (deprecated) milestone Apr 6, 2020
@dotarmin
Copy link
Contributor

dotarmin commented Apr 7, 2020

Will be fixed by #1244 but the PR needs to be fixed before it can be merged.

@dotarmin dotarmin added this to the v2.3.0 LTS milestone Apr 7, 2020
@krzyc
Copy link
Contributor

krzyc commented Apr 8, 2020

@dotarmin I have resolved conflicts. Do you have other suggestions?

@dotarmin dotarmin assigned ronag and unassigned Julusian and ronag Apr 8, 2020
@Julusian
Copy link
Member

This is partially resolved by #1244. The CEF renderer will now be mostly cleaned up along with any frames, but the producer will still exist

@ronag ronag modified the milestones: v2.3.0 LTS, v2.3.1 LTS May 28, 2020
@scriptorian scriptorian linked a pull request Jun 25, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
html type/bug
Projects
None yet
Milestone
v2.3.1 LTS
Development

Successfully merging a pull request may close this issue.

CG REMOVE should destruct html producer scriptorian/server
4 participants
@krzyc @Julusian @ronag @dotarmin