Add resolve_address method on v0 init actor #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creativcoder
requested review from
hanabi1224,
elmattic,
lemmih,
LesnyRumcajs,
jdjaustin and
sudo-shashank
as code owners
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
- Coverage 10.70% 10.69% -0.01%
==========================================
Files 319 319
Lines 29046 29057 +11
==========================================
Hits 3109 3109
- Misses 25937 25948 +11
☔ View full report in Codecov by Sentry. |
lemmih
reviewed
Jun 23, 2023
| @@ -2,8 +2,13 @@ | |||
| // SPDX-License-Identifier: Apache-2.0, MIT | |||
|
|
|||
| use cid::Cid; | |||
| use fil_actors_shared::v9::{make_map_with_root_and_bitwidth, shared::HAMT_BIT_WIDTH}; | |||
There was a problem hiding this comment.
Are you sure the v9 versions of these functions are identical to the v0 versions?
There was a problem hiding this comment.
Sorry intended to raise this as draft PR, will test and confirm
|
Closing this PR. Going forward, we'll add support for older actors as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #148
Other information and links