Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move extra methods from actor states #338

Open
LesnyRumcajs opened this issue Oct 14, 2024 · 2 comments
Open

Move extra methods from actor states #338

LesnyRumcajs opened this issue Oct 14, 2024 · 2 comments
Assignees

Comments

@LesnyRumcajs
Copy link
Member

LesnyRumcajs commented Oct 14, 2024

Issue summary

Actor state files must remain as close to their source as possible. They should not be extended by additional methods directly like in #290. All such occurrences should be moved to, e.g., Forest shim or extension traits.

This is should lower the upgrade burden (less manual copy-pasting from our own definitions - only from the builtin-actors) and manage our expectations for the given methods (builtin-actors code is the holy grail and we should assume it's correct, otherwise it's a massive issue for Filecoin networks).

Other information and links

@LesnyRumcajs
Copy link
Member Author

@sudo-shashank Could you please identify which methods are "our own" and should be migrated elsewhere?

@sudo-shashank
Copy link
Contributor

@sudo-shashank Could you please identify which methods are "our own" and should be migrated elsewhere?

okay sure

@sudo-shashank sudo-shashank self-assigned this Oct 24, 2024
@sudo-shashank sudo-shashank moved this from New to Ready in Forest Backlog 🌲 Oct 24, 2024
@LesnyRumcajs LesnyRumcajs moved this from Ready to In progress in Forest Backlog 🌲 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

2 participants