Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc) Filecoin.EthGetTransactionCount #4487

Merged
merged 6 commits into from
Jul 5, 2024

Conversation

sudo-shashank
Copy link
Contributor

@sudo-shashank sudo-shashank commented Jul 5, 2024

Summary of changes

Changes introduced in this pull request:

  • Impl Filecoin.EthGetTransactionCount RPC and Test
| RPC Method                           | Forest | Lotus      |
|--------------------------------------|--------|------------|
| Filecoin.EthGetTransactionCount (10) | Valid  | Valid      |

Reference issue to close (if applicable)

Contributes to #4165

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@sudo-shashank sudo-shashank marked this pull request as ready for review July 5, 2024 11:56
@sudo-shashank sudo-shashank requested a review from a team as a code owner July 5, 2024 11:56
@sudo-shashank sudo-shashank requested review from ruseinov and LesnyRumcajs and removed request for a team July 5, 2024 11:56
@sudo-shashank sudo-shashank mentioned this pull request Jul 5, 2024
40 tasks
@sudo-shashank sudo-shashank added this pull request to the merge queue Jul 5, 2024
Merged via the queue into main with commit 630c206 Jul 5, 2024
48 checks passed
@sudo-shashank sudo-shashank deleted the shashank/eth-transaction-count-rpc branch July 5, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants