Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter logs for only the block being queried #5016

Closed
wants to merge 7 commits into from

Conversation

virajbhartiya
Copy link
Contributor

Summary of changes

Changes introduced in this pull request:
src/rpc/methods/eth.rs: Added logic to filter events based on the current block hash in the new_eth_tx_receipt function. This ensures that only events matching the current block hash are retained.

Reference issue to close (if applicable)

Closes #5006

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@virajbhartiya virajbhartiya requested a review from a team as a code owner November 28, 2024 12:55
@virajbhartiya virajbhartiya requested review from ruseinov and hanabi1224 and removed request for a team November 28, 2024 12:55
src/rpc/methods/eth.rs Outdated Show resolved Hide resolved
src/rpc/methods/eth.rs Outdated Show resolved Hide resolved
@elmattic
Copy link
Contributor

Let's close this PR if we're not 100% how to fix this flakyness.

@elmattic elmattic closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RPC] Flaky Filecoin.EthGetBlockReceipts test
3 participants