Memory Wallet Implementation #10
willemoldingaudits.yml
on: pull_request
Vet Rust dependencies
2m 18s
Check licenses
39s
Annotations
4 errors
|
unnecessary closure used to substitute value for `Option::None`:
zcash_client_memory/src/mem_wallet/wallet_write.rs#L58
error: unnecessary closure used to substitute value for `Option::None`
--> zcash_client_memory/src/mem_wallet/wallet_write.rs:58:22
|
58 | .map(|a| a.next().ok_or_else(|| Self::Error::AccountOutOfRange))
| ^^^^^^^^^---------------------------------------------
| |
| help: use `ok_or(..)` instead: `ok_or(Self::Error::AccountOutOfRange)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
|
|
unnecessary closure used to substitute value for `Option::None`:
zcash_client_memory/src/mem_wallet/wallet_write.rs#L53
error: unnecessary closure used to substitute value for `Option::None`
--> zcash_client_memory/src/mem_wallet/wallet_write.rs:53:32
|
53 | let seed_fingerprint = SeedFingerprint::from_seed(seed.expose_secret())
| ________________________________^
54 | | .ok_or_else(|| Self::Error::InvalidSeedLength)?;
| |______________--------------------------------------------^
| |
| help: use `ok_or(..)` instead: `ok_or(Self::Error::InvalidSeedLength)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: `-D clippy::unnecessary-lazy-evaluations` implied by `-D warnings`
|
|
using `clone` on type `TransparentAddress` which implements the `Copy` trait:
zcash_client_memory/src/mem_wallet/wallet_read.rs#L264
error: using `clone` on type `TransparentAddress` which implements the `Copy` trait
--> zcash_client_memory/src/mem_wallet/wallet_read.rs:264:32
|
264 | let addr = output.recipient_address().clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*output.recipient_address()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `-D clippy::clone-on-copy` implied by `-D warnings`
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
zcash_client_memory/src/mem_wallet/wallet_read.rs#L259
error: this expression creates a reference which is immediately dereferenced by the compiler
--> zcash_client_memory/src/mem_wallet/wallet_read.rs:259:35
|
259 | .contains_key(&outpoint)
| ^^^^^^^^^ help: change this to: `outpoint`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
|