feat: implement EIP-7742 #7232
Draft
feat: implement EIP-7742 #7232
+52
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devnet-5 #7232 +/- ##
============================================
- Coverage 49.08% 48.40% -0.68%
============================================
Files 600 602 +2
Lines 40241 40355 +114
Branches 2110 2062 -48
============================================
- Hits 19753 19535 -218
- Misses 20450 20782 +332
Partials 38 38 |
Performance Report✔️ no performance regression detected Full benchmark results
|
|
Included for alpha.10 |
nflaig
reviewed
Nov 29, 2024
| @@ -284,4 +288,20 @@ Will double processing times. Use only for debugging purposes.", | |||
| default: defaultOptions.chain.maxCPStateEpochsInMemory, | |||
| group: "chain", | |||
| }, | |||
|
|
|||
| "chain.targetBlobsPerBlock": { | |||
There was a problem hiding this comment.
these values will be part of spec config
There was a problem hiding this comment.
Setting 4/8 or 6/9 is part of the scope of EIP-7691. Will open a separate PR for it.
EIP-7742 only sets target = max / 2 and no new config value
This reverts commit 26b6bc6.
twoeths
reviewed
Dec 10, 2024
| (payloadAttributes as electra.SSEPayloadAttributes["payloadAttributes"]).targetBlobsPerBlock = Math.floor( | ||
| MAX_BLOBS_PER_BLOCK / 2 | ||
| ); | ||
| (payloadAttributes as electra.SSEPayloadAttributes["payloadAttributes"]).maxBlobsPerBlock = MAX_BLOBS_PER_BLOCK; |
There was a problem hiding this comment.
cast to electra.SSEPayloadAttributes once
twoeths
reviewed
Dec 10, 2024
| @@ -201,7 +201,8 @@ export class ExecutionEngineHttp implements IExecutionEngine { | |||
| executionPayload: ExecutionPayload, | |||
| versionedHashes?: VersionedHashes, | |||
| parentBlockRoot?: Root, | |||
| executionRequests?: ExecutionRequests | |||
| executionRequests?: ExecutionRequests, | |||
| maxBlobsPerBlock?: number | |||
There was a problem hiding this comment.
verifyBlocksExecutionPayload passed in targetBlobsPerBlock which is correct as in the api but here it's maxBlobsPerBlock
|
need to wait for eip-7742 execution api to be merged |
|
Converting to draft as there is a blocker for the EIP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7176