Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing access modifier for Heirloom.MiniAudio #20

Open
asrulhadi opened this issue Jan 5, 2023 · 7 comments
Open

Consider changing access modifier for Heirloom.MiniAudio #20

asrulhadi opened this issue Jan 5, 2023 · 7 comments

Comments

@asrulhadi
Copy link

Hi,

Would you consider changing Heirloom.MiniAudio from internal class es to public class?

This will give access for other project to used it, independently from Heirloom framework.

@Chamberlain91
Copy link
Owner

It's a bit more complicated than a simple binding for MA. I had to write my own C layer to adapt the structs because MA (at least at the time of writing it) would have a different context struct depending on the platform it was compiled for. So I wrote a wrapper in C to allocate and expose only the parts I needed to C#.

I could consider revisiting and maybe rewriting a new C# bindings if that's what you're hoping for. Would be a lot of work, but if there isn't one available yet it might be worth it.

@asrulhadi
Copy link
Author

Currently I am looking for a portable audio player for my project.
Need basic requirement. Just need to play sound file.
Modifying your code with appropriate access level could complete the job.

Would you mine if I fork your repo and use for my project?

@Chamberlain91
Copy link
Owner

It should be able to already play mp3 or ogg files with my abstraction. Why do you need the lower level MA functions?

@asrulhadi
Copy link
Author

So, you have abstracted it in the development branch.
I am just looking into the master branch. My Bad.

Looking into the code, it should be sufficient for my needs.

@Chamberlain91
Copy link
Owner

Awesome. Keep me up to date. I am quite interested that someone found this project

@asrulhadi
Copy link
Author

A plan to publish nuget?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants