Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the package name to channelape #38

Open
kennethjor opened this issue Jun 8, 2020 · 1 comment
Open

Change the package name to channelape #38

kennethjor opened this issue Jun 8, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kennethjor
Copy link
Contributor

This may be a pedantic nitpicky thing, but it doesn't seem right to publish the SDK using the com.shopify package. It implies an official endorsement where none exists. Perhaps this should be changed to com.channelape.shopify?

@rjdavis3
Copy link
Member

Thanks for the suggestion @kennethjor . We mainly did this for our own internal use when this repo was closed source.

I understand where your suggestion is coming from and we will consider this for a 3.0.0 release as it would be a breaking change.

@rjdavis3 rjdavis3 self-assigned this Jun 19, 2020
@rjdavis3 rjdavis3 added 3.0.0 enhancement New feature or request labels Jun 19, 2020
@rjdavis3 rjdavis3 added this to the 3.0.0 milestone Jun 19, 2020
@rjdavis3 rjdavis3 removed the 3.0.0 label Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants